♻️🎨 [Frontend] Study Store #8087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
…into enh/study-store
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes all study-related API interactions into a singleton osparc.store.Study, replacing ad-hoc osparc.data.Resources.fetch("studies", …) calls in UI components with calls to Study.getInstance(), and adds a suite of new store methods for pagination, trash/untrash, moving, tagging, collaborators, and node operations.
- Replaced direct resource fetches across many components with
osparc.store.Study.getInstance()calls - Converted
osparc.store.Studyto a singleton and added new methods (getPage, trashStudy, moveStudyToWorkspace, addTag, removeCollaborator, etc.) - Removed duplicated static methods from the generic
Store.jsin favor of the specializedStudystore
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/study/StudyOptions.js | Switched name, wallet and fetch calls to Study.getInstance() |
| services/static-webserver/client/source/class/osparc/study/NodePricingUnits.js | Updated pricing-unit fetch/update to use Study singleton |
| services/static-webserver/client/source/class/osparc/study/CreateFunction.js | Replaced metadata PATCH fetch with store.updateMetadata |
| services/static-webserver/client/source/class/osparc/study/BillingSettings.js | Centralized wallet selection via Study singleton |
| services/static-webserver/client/source/class/osparc/store/Templates.js | Delegated template fetching to Study.getInstance().getOne |
| services/static-webserver/client/source/class/osparc/store/Study.js | Converted to a singleton, added CRUD, pagination, tag, collaborator APIs |
| services/static-webserver/client/source/class/osparc/store/Store.js | Removed study‐specific static methods now in Study store |
| services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js | Replaced fetch calls (getPage, getOne, delete, patch) with store calls |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js | Moved delete, untrash, patch, pricing workflows into Study singleton |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/store/Study.js:110
- The
updateMetadatamethod does not return the fetch promise, preventing callers from waiting on or handling errors. Addreturnbefore the fetch call to enable proper chaining.
osparc.data.Resources.fetch("studies", "updateMetadata", params)
services/static-webserver/client/source/class/osparc/store/Study.js:26
- New pagination methods (
getPage,getPageTrashed,getPageSearch) were added without accompanying unit or integration tests. Consider adding tests to ensure correct behavior and catch any regressions.
getPage: function(params, options) {
services/static-webserver/client/source/class/osparc/study/BillingSettings.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
…into enh/study-store
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to get ready for the coming "multiple users access the same study at the same time" feature, this PR centralizes most of the study related calls in the Study Store.
The idea is to have the Study model managed in the Store while it's able to listen to changes pushed from the backend (other users).
Related issue/s
How to test
Dev-ops